feat: include entity coords if entity is defined #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I moved the logic for fetching the coords to right before triggering the event, as the prop might have moved since its definition. |
3 tasks
ItzMuri
added a commit
to ItzMuri/qb-target
that referenced
this pull request
Oct 25, 2024
feat: include entity coords if entity is defined (qbcore-framework#203)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Pull request
This PR makes sure that the coordinates of said entity are included in the data passed upon trigger events.
This is useful as you can't fetch these coordinateson the server side.
This solves an issue in the inventory, where the vending machines are defined via
AddTargetModel.https://github.com/qbcore-framework/qb-inventory/blob/ed5388d2430cbd24d187b984bd827c4f38425a9c/client/main.lua#L274-L286
To later be used via a server event, which requires the coordinates, but are undefined/null at the moment as there's no way of fetching them.
https://github.com/qbcore-framework/qb-inventory/blob/ed5388d2430cbd24d187b984bd827c4f38425a9c/server/main.lua#L142
This needs to be merged alongside this PR:
qbcore-framework/qb-inventory#518
Questions (please complete the following information):